Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide guidance for how to handle secrets and forks from PRs. #24

Open
2color opened this issue Mar 4, 2025 · 1 comment
Open

Provide guidance for how to handle secrets and forks from PRs. #24

2color opened this issue Mar 4, 2025 · 1 comment

Comments

@2color
Copy link
Member

2color commented Mar 4, 2025

Problem

When a pull request is created from a fork and the workflow runs (via the pull_request event, it has no access to the secrets of the base repository. This is sensible for security, but there might be situations where you want to allow the pull request to run, for example after reviewing it and confirming it has no malicious changes.

Example PR: ipfs/ipfs-blog#707

What should we do?

We should document how to deal with this case in the README.md with all the risks invovled. Since this action doesn't make any assumptions or dictate your workflow, it's ultimately up to users of this actions to decide how to use it.

It may be possible to use the pull_request_target event for this purpose.

@2color
Copy link
Member Author

2color commented Mar 5, 2025

Update: ipfs/ipfs-blog#711 looks into this.

Once we make a decision, I'll document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant