Revert "blockservice: make ContextWithSession shortcut grabSessionFromContext inside newSession"

Jorropo · Jorropo · commit 4b8ade1c13ca · 2024-02-16T15:07:50.000+01:00
Supperseeded by #570 This reverts commit ea04c77.
diff --git a/blockservice/blockservice.go b/blockservice/blockservice.go
@@ -483,7 +483,7 @@ func ContextWithSession(ctx context.Context, bs BlockService) context.Context {
 	if grabSessionFromContext(ctx, bs) != nil {
 		return ctx
 	}
-	return EmbedSessionInContext(ctx, newSession(ctx, bs))
+	return EmbedSessionInContext(ctx, NewSession(ctx, bs))
 }
 
 // EmbedSessionInContext is like [ContextWithSession] but it allows to embed an existing session.

Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,7 @@ func ContextWithSession(ctx context.Context, bs BlockService) context.Context {`
`483`	`483`	`if grabSessionFromContext(ctx, bs) != nil {`
`484`	`484`	`return ctx`
`485`	`485`	`}`
`486`		`- return EmbedSessionInContext(ctx, newSession(ctx, bs))`
	`486`	`+ return EmbedSessionInContext(ctx, NewSession(ctx, bs))`
`487`	`487`	`}`
`488`	`488`
`489`	`489`	`// EmbedSessionInContext is like [ContextWithSession] but it allows to embed an existing session.`