Skip to content

Commit dc644b5

Browse files
borkmannkuba-moo
authored andcommitted
tcx: Fix splat in ingress_destroy upon tcx_entry_free
On qdisc destruction, the ingress_destroy() needs to update the correct entry, that is, tcx_entry_update must NULL the dev->tcx_ingress pointer. Therefore, fix the typo. Fixes: e420bed ("bpf: Add fd-based tcx multi-prog infra with link support") Reported-by: [email protected] Reported-by: [email protected] Reported-by: [email protected] Signed-off-by: Daniel Borkmann <[email protected]> Tested-by: [email protected] Tested-by: [email protected] Tested-by: [email protected] Tested-by: Petr Machata <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 5322a27 commit dc644b5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/sched/sch_ingress.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ static void ingress_destroy(struct Qdisc *sch)
123123
if (entry) {
124124
tcx_miniq_set_active(entry, false);
125125
if (!tcx_entry_is_active(entry)) {
126-
tcx_entry_update(dev, NULL, false);
126+
tcx_entry_update(dev, NULL, true);
127127
tcx_entry_free(entry);
128128
}
129129
}

0 commit comments

Comments
 (0)