Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default argument for decode_timedelta #706

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update default argument for decode_timedelta #706

wants to merge 3 commits into from

Conversation

charles-turner-1
Copy link
Collaborator

@charles-turner-1 charles-turner-1 commented Mar 5, 2025 •
edited
Loading

Change Summary

Change default decode_timedelta xarray_open_kwarg to False, following change to xarray default:

 FutureWarning: In a future version of xarray decode_timedelta will default to False rather than None. To silence this warning, set decode_timedelta to True, False, or a 'CFTimedeltaCoder' instance.

Related issue number

Closes #702

Checklist

  • [NA] Unit tests for the changes exist
  • Tests pass on CI
  • [NA] Documentation reflects the changes where applicable - I can't see any references to the default arguments passed to xarray.open_mfdataset anywhere in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 Awaiting requested review from mgrover1 mgrover1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change in xarray default causing large number of warnings
1 participant
@charles-turner-1