Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action -> actionCreator? #1

Closed
gaearon opened this issue Jul 18, 2015 · 2 comments
Closed

action -> actionCreator? #1

gaearon opened this issue Jul 18, 2015 · 2 comments

Comments

@gaearon
Copy link

gaearon commented Jul 18, 2015

One of the most common source of confusion with Flux libraries is that people say “action” when they mean two very different concepts (“action” and “action creator”).

To avoid adding to the confusion, I'd rather rename action to actionCreator in this API. It's not much more to type, but is much less confusing to the beginners.

What do you think?

@insin
Copy link
Owner

insin commented Jul 18, 2015

Yes, better to be correct than terse, and you can always alias the functions yourself if you want.

Will publish a new version shortly.

@insin insin closed this as completed in 93b5c09 Jul 18, 2015
@gaearon
Copy link
Author

gaearon commented Jul 18, 2015

👍 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants