Skip to content

Commit c11c24d

Browse files
committed
google#2130 - Stop skipping certain tests under Windows
While on local machine the test cases took roughly similar times both on Windows and on Unix, on GitHub CI the tests under Windows took more than 1 hour (!). Keeping two test cases excluded that were previously measured to be slow.
1 parent a316d3e commit c11c24d

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

guava-tests/test/com/google/common/util/concurrent/AbstractFutureTest.java

+10
Original file line numberDiff line numberDiff line change
@@ -437,6 +437,9 @@ public void run() {
437437
*/
438438

439439
public void testFutureBash() {
440+
if (isWindows()) {
441+
return; // TODO: b/136041958 - Running very slowly on Windows.
442+
}
440443
final CyclicBarrier barrier =
441444
new CyclicBarrier(
442445
6 // for the setter threads
@@ -618,6 +621,9 @@ public void run() {
618621

619622
// setFuture and cancel() interact in more complicated ways than the other setters.
620623
public void testSetFutureCancelBash() {
624+
if (isWindows()) {
625+
return; // TODO: b/136041958 - Running very slowly on Windows.
626+
}
621627
final int size = 50;
622628
final CyclicBarrier barrier =
623629
new CyclicBarrier(
@@ -1326,4 +1332,8 @@ protected void interruptTask() {
13261332
interruptTaskWasCalled = true;
13271333
}
13281334
}
1335+
1336+
private static boolean isWindows() {
1337+
return OS_NAME.value().startsWith("Windows");
1338+
}
13291339
}

0 commit comments

Comments
 (0)