fix(server): correct getting messages by timestamp from unsaved_buffer #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubcio
force-pushed
the
timestamp-fix
branch
2 times, most recently
from
3ea3b10 to
296d837
Compare
This commit fixed functionality to retrieve messages by timestamp when all messages are stored in the unsaved buffer. The changes include modifications to the `BatchAccumulator` and `Segment` classes to handle timestamp-based retrieval efficiently. The `get_messages_by_timestamp` method has been added to both classes, allowing for precise message retrieval based on timestamps.
hubcio
force-pushed
the
timestamp-fix
branch
from
296d837 to
1dcda97
Compare
spetz
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixed functionality to retrieve messages by timestamp
when all messages are stored in the unsaved buffer. The changes include
modifications to the
BatchAccumulatorandSegmentstructs to handletimestamp-based retrieval efficiently. The
get_messages_by_timestampmethod has been added to both strcuts, allowing for precise message
retrieval based on timestamps.