fix(server): release lock before async save to prevent deadlock #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubcio
force-pushed
the
dashmap-deadlock
branch
2 times, most recently
from
6c46ab1 to
a7fa4e5
Compare
spetz
previously approved these changes
Feb 21, 2025
- In `consumer_offsets.rs`, clone the consumer offset's path and drop the mutable guard before awaiting the async save. - Refactor `save_consumer_offset` to accept a new offset value and path instead of a ConsumerOffset reference. - Update error messages and trace logs accordingly. - Bump version in Cargo.toml from 0.4.210 to 0.4.211.
hubcio
force-pushed
the
dashmap-deadlock
branch
from
a7fa4e5 to
deb8387
Compare
spetz
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consumer_offsets.rs, clone the consumer offset's path anddrop the mutable guard before awaiting the async save.
save_consumer_offsetto accept a new offset valueand path instead of a ConsumerOffset reference.