fix(server): fix get_messages_by_timestamp logic
#1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubcio
force-pushed
the
fix-get-by-timestamp
branch
2 times, most recently
from
53ca5fb to
62470c8
Compare
This commit refactors the `get_messages_by_timestamp` function to improve efficiency and readability. The changes include: - Simplified logic for finding the starting segment and offset. - Removed unnecessary calculations and variables. - Enhanced error handling with more detailed context. - Improved message filtering and collection logic. - Removed redundant functions and code for better maintainability. Besides that, added additional 288 testcases that test both `get_messages_by_timestamp` and `get_messages_by_offset` to improve robustness of iggy-server.
hubcio
force-pushed
the
fix-get-by-timestamp
branch
from
62470c8 to
e3e65b7
Compare
spetz
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the
get_messages_by_timestampfunctionto improve efficiency and readability. The changes include:
Besides that, added additional 288 testcases that test both
get_messages_by_timestampandget_messages_by_offsetto improverobustness of iggy-server.