Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add perPage param to get users endpoint #353

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Add perPage param to get users endpoint #353

merged 2 commits into from
Nov 12, 2020

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Nov 11, 2020 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Adds perPage query param to get users endpoint (also clarifies some method names in Auth0Users).

landonreed added a commit to ibi-group/datatools-ui that referenced this pull request Nov 11, 2020
@landonreed
feat(UserList): add users per page selector
0445e12 
works with changes in ibi-group/datatools-server#353
@landonreed landonreed mentioned this pull request Nov 11, 2020
Merged
5 tasks
@evansiroky evansiroky removed their assignment Nov 12, 2020
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe rename perPage to itemsPerPage.

@landonreed landonreed merged commit 2fe1662 into dev Nov 12, 2020
@landonreed landonreed deleted the add-per-page branch November 12, 2020 15:16
@landonreed landonreed mentioned this pull request Mar 9, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansiroky evansiroky evansiroky approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@landonreed landonreed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@landonreed @evansiroky @binh-dam-ibigroup