Remove legacy InspectorPackagerConnection (facebook#44746)

Summary:

Cleanup after this experiment's removal in D57730921.

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D58017460

Author: huntie

packages/react-native/React/DevSupport/RCTInspectorDevServerHelper.mm

@@ -14,7 +14,6 @@
 
 #import <React/RCTCxxInspectorPackagerConnection.h>
 #import <React/RCTDefines.h>
-#import <React/RCTInspectorPackagerConnection.h>
 
 #import <CommonCrypto/CommonCrypto.h>
 #import <jsinspector-modern/InspectorFlags.h>
@@ -181,12 +180,7 @@ + (void)disableDebugger
   NSString *key = [inspectorURL absoluteString];
   id<RCTInspectorPackagerConnectionProtocol> connection = socketConnections[key];
   if (!connection || !connection.isConnected) {
-    if (facebook::react::jsinspector_modern::InspectorFlags::getInstance().getFuseboxEnabled()) {
-      connection = [[RCTCxxInspectorPackagerConnection alloc] initWithURL:inspectorURL];
-    } else {
-      // TODO(T190163403): Remove legacy RCTInspectorPackagerConnection
-      connection = [[RCTInspectorPackagerConnection alloc] initWithURL:inspectorURL];
-    }
+    connection = [[RCTCxxInspectorPackagerConnection alloc] initWithURL:inspectorURL];
 
     socketConnections[key] = connection;
     [connection connect];

packages/react-native/React/Inspector/RCTInspectorPackagerConnection.m

@@ -2184,13 +2184,6 @@ public final class com/facebook/react/devsupport/InspectorFlags {
 	public static final fun getFuseboxEnabled ()Z
 }
 
-public class com/facebook/react/devsupport/InspectorPackagerConnection : com/facebook/react/devsupport/IInspectorPackagerConnection {
-	public fun <init> (Ljava/lang/String;Ljava/lang/String;)V
-	public fun closeQuietly ()V
-	public fun connect ()V
-	public fun sendEventToAllConnections (Ljava/lang/String;)V
-}
-
 public class com/facebook/react/devsupport/JSCHeapCapture : com/facebook/fbreact/specs/NativeJSCHeapCaptureSpec {
 	public fun <init> (Lcom/facebook/react/bridge/ReactApplicationContext;)V
 	public fun captureComplete (Ljava/lang/String;Ljava/lang/String;)V

packages/react-native/ReactAndroid/api/ReactAndroid.api

@@ -210,14 +210,8 @@ public void openInspectorConnection() {
     new AsyncTask<Void, Void, Void>() {
       @Override
       protected Void doInBackground(Void... params) {
-        if (InspectorFlags.getFuseboxEnabled()) {
-          mInspectorPackagerConnection =
-              new CxxInspectorPackagerConnection(getInspectorDeviceUrl(), mPackageName);
-        } else {
-          // TODO(T190163403): Remove legacy InspectorPackagerConnection
-          mInspectorPackagerConnection =
-              new InspectorPackagerConnection(getInspectorDeviceUrl(), mPackageName);
-        }
+        mInspectorPackagerConnection =
+            new CxxInspectorPackagerConnection(getInspectorDeviceUrl(), mPackageName);
         mInspectorPackagerConnection.connect();
         return null;
       }