Copy UUID impl (microsoft#231347)

Author: rzhao271

extensions/ipynb/src/helper.ts

@@ -147,13 +147,15 @@ export interface ITask<T> {
 /**
  * Copied from src/vs/base/common/uuid.ts
  */
-export function generateUuid() {
-	// use `randomValues` if possible
-	function getRandomValues(bucket: Uint8Array): Uint8Array {
-		for (let i = 0; i < bucket.length; i++) {
-			bucket[i] = Math.floor(Math.random() * 256);
-		}
-		return bucket;
+export function generateUuid(): string {
+	// use `randomUUID` if possible
+	if (typeof crypto.randomUUID === 'function') {
+		// see https://developer.mozilla.org/en-US/docs/Web/API/Window/crypto
+		// > Although crypto is available on all windows, the returned Crypto object only has one
+		// > usable feature in insecure contexts: the getRandomValues() method.
+		// > In general, you should use this API only in secure contexts.
+
+		return crypto.randomUUID.bind(crypto).toString();
 	}
 
 	// prep-work
@@ -164,7 +166,7 @@ export function generateUuid() {
 	}
 
 	// get data
-	getRandomValues(_data);
+	crypto.getRandomValues(_data);
 
 	// set version bits
 	_data[6] = (_data[6] & 0x0f) | 0x40;

test/automation/src/profiler.ts

@@ -55,13 +55,18 @@ export class Profiler {
 	}
 }
 
-function generateUuid() {
-	// use `randomValues` if possible
-	function getRandomValues(bucket: Uint8Array): Uint8Array {
-		for (let i = 0; i < bucket.length; i++) {
-			bucket[i] = Math.floor(Math.random() * 256);
-		}
-		return bucket;
+/**
+ * Copied from src/vs/base/common/uuid.ts
+ */
+export function generateUuid(): string {
+	// use `randomUUID` if possible
+	if (typeof crypto.randomUUID === 'function') {
+		// see https://developer.mozilla.org/en-US/docs/Web/API/Window/crypto
+		// > Although crypto is available on all windows, the returned Crypto object only has one
+		// > usable feature in insecure contexts: the getRandomValues() method.
+		// > In general, you should use this API only in secure contexts.
+
+		return crypto.randomUUID.bind(crypto).toString();
 	}
 
 	// prep-work
@@ -72,7 +77,7 @@ function generateUuid() {
 	}
 
 	// get data
-	getRandomValues(_data);
+	crypto.getRandomValues(_data);
 
 	// set version bits
 	_data[6] = (_data[6] & 0x0f) | 0x40;