Skip to content

Commit e67dc1e

Browse files
committedJan 15, 2020
build: remove enable_vtune from vcbuild.bat
vcbuild.bat wasn't updated when vtune support was removed in nodejs#28522 Refs: nodejs#28522 PR-URL: nodejs#31338 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent d830ff8 commit e67dc1e

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed
 

‎vcbuild.bat

+1-5
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ set noetw_msi_arg=
4949
set i18n_arg=
5050
set download_arg=
5151
set build_release=
52-
set enable_vtune_arg=
5352
set configure_flags=
5453
set build_addons=
5554
set dll=
@@ -135,7 +134,6 @@ if /i "%1"=="intl-none" set i18n_arg=none&goto arg-ok
135134
if /i "%1"=="without-intl" set i18n_arg=none&goto arg-ok
136135
if /i "%1"=="download-all" set download_arg="--download=all"&goto arg-ok
137136
if /i "%1"=="ignore-flaky" set test_args=%test_args% --flaky-tests=dontcare&goto arg-ok
138-
if /i "%1"=="enable-vtune" set enable_vtune_arg=1&goto arg-ok
139137
if /i "%1"=="dll" set dll=1&goto arg-ok
140138
if /i "%1"=="static" set enable_static=1&goto arg-ok
141139
if /i "%1"=="no-NODE-OPTIONS" set no_NODE_OPTIONS=1&goto arg-ok
@@ -189,7 +187,6 @@ if defined noetw set configure_flags=%configure_flags% --without-etw&
189187
if defined ltcg set configure_flags=%configure_flags% --with-ltcg
190188
if defined release_urlbase set configure_flags=%configure_flags% --release-urlbase=%release_urlbase%
191189
if defined download_arg set configure_flags=%configure_flags% %download_arg%
192-
if defined enable_vtune_arg set configure_flags=%configure_flags% --enable-vtune-profiling
193190
if defined dll set configure_flags=%configure_flags% --shared
194191
if defined enable_static set configure_flags=%configure_flags% --enable-static
195192
if defined no_NODE_OPTIONS set configure_flags=%configure_flags% --without-node-options
@@ -706,14 +703,13 @@ del .used_configure_flags
706703
goto exit
707704

708705
:help
709-
echo vcbuild.bat [debug/release] [msi] [doc] [test/test-all/test-addons/test-js-native-api/test-node-api/test-benchmark/test-internet/test-pummel/test-simple/test-message/test-tick-processor/test-known-issues/test-node-inspect/test-check-deopts/test-npm/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [ignore-flaky] [static/dll] [noprojgen] [projgen] [small-icu/full-icu/without-intl] [nobuild] [nosnapshot] [noetw] [ltcg] [licensetf] [sign] [ia32/x86/x64/arm64] [vs2017/vs2019] [download-all] [enable-vtune] [lint/lint-ci/lint-js/lint-js-ci/lint-md] [lint-md-build] [package] [build-release] [upload] [no-NODE-OPTIONS] [link-module path-to-module] [debug-http2] [debug-nghttp2] [clean] [cctest] [no-cctest] [openssl-no-asm]
706+
echo vcbuild.bat [debug/release] [msi] [doc] [test/test-all/test-addons/test-js-native-api/test-node-api/test-benchmark/test-internet/test-pummel/test-simple/test-message/test-tick-processor/test-known-issues/test-node-inspect/test-check-deopts/test-npm/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [ignore-flaky] [static/dll] [noprojgen] [projgen] [small-icu/full-icu/without-intl] [nobuild] [nosnapshot] [noetw] [ltcg] [licensetf] [sign] [ia32/x86/x64/arm64] [vs2017/vs2019] [download-all] [lint/lint-ci/lint-js/lint-js-ci/lint-md] [lint-md-build] [package] [build-release] [upload] [no-NODE-OPTIONS] [link-module path-to-module] [debug-http2] [debug-nghttp2] [clean] [cctest] [no-cctest] [openssl-no-asm]
710707
echo Examples:
711708
echo vcbuild.bat : builds release build
712709
echo vcbuild.bat debug : builds debug build
713710
echo vcbuild.bat release msi : builds release build and MSI installer package
714711
echo vcbuild.bat test : builds debug build and runs tests
715712
echo vcbuild.bat build-release : builds the release distribution as used by nodejs.org
716-
echo vcbuild.bat enable-vtune : builds nodejs with Intel VTune profiling support to profile JavaScript
717713
echo vcbuild.bat link-module my_module.js : bundles my_module as built-in module
718714
echo vcbuild.bat lint : runs the C++, documentation and JavaScript linter
719715
echo vcbuild.bat no-cctest : skip building cctest.exe

0 commit comments

Comments
 (0)
Please sign in to comment.