Skip to content

Commit a173173

Browse files
committedJun 30, 2019
tools: change editorconfig's 'ignore' to 'unset'
According to https://editorconfig.org/#supported-properties the canonical way to disable a property is to set it to 'unset'. We did use 'ignore' and this generally works because tools ignore unknown values but some of them like `eclint` are picky on it. PR-URL: nodejs#28440 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent 8772da6 commit a173173

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed
 

‎.editorconfig

+5-5
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ indent_size = 8
1616
indent_style = tab
1717

1818
[{deps}/**]
19-
charset = ignore
20-
end_of_line = ignore
21-
indent_size = ignore
22-
indent_style = ignore
23-
trim_trailing_whitespace = ignore
19+
charset = unset
20+
end_of_line = unset
21+
indent_size = unset
22+
indent_style = unset
23+
trim_trailing_whitespace = unset
2424

2525
[{test/fixtures,deps,tools/node_modules,tools/gyp,tools/icu,tools/msvs}/**]
2626
insert_final_newline = false

0 commit comments

Comments
 (0)
Please sign in to comment.