Skip to content

Commit 678e1be

Browse files
addaleaxmmarchini
authored andcommittedMar 23, 2020
src: delete CallbackInfo when cleared from cleanup hook
Fixes: nodejs#32400 PR-URL: nodejs#32405 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent f2cc28a commit 678e1be

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎src/node_buffer.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -163,14 +163,14 @@ void CallbackInfo::WeakCallback(
163163
const WeakCallbackInfo<CallbackInfo>& data) {
164164
CallbackInfo* self = data.GetParameter();
165165
self->WeakCallback(data.GetIsolate());
166-
delete self;
167166
}
168167

169168

170169
void CallbackInfo::WeakCallback(Isolate* isolate) {
171170
callback_(data_, hint_);
172171
int64_t change_in_bytes = -static_cast<int64_t>(sizeof(*this));
173172
isolate->AdjustAmountOfExternalAllocatedMemory(change_in_bytes);
173+
delete this;
174174
}
175175

176176

0 commit comments

Comments
 (0)
Please sign in to comment.