Skip to content

Commit 1995eca

Browse files
committedSep 17, 2023
build: run embedtest using node executable
We should use the node executable to run this test, instead of counting on embedtest, the binary being tested, as the test runner. Otherwise bugs can go unnoticed if the embedtest binary itself does not work correctly. PR-URL: nodejs#49506 Fixes: nodejs#49501 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 76ac548 commit 1995eca

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ coverage-report-js:
286286
# Runs the C++ tests using the built `cctest` executable.
287287
cctest: all
288288
@out/$(BUILDTYPE)/$@ --gtest_filter=$(GTEST_FILTER)
289-
@out/$(BUILDTYPE)/embedtest "require('./test/embedding/test-embedding.js')"
289+
$(NODE) ./test/embedding/test-embedding.js
290290

291291
.PHONY: list-gtests
292292
list-gtests:
@@ -550,7 +550,7 @@ test-ci: | clear-stalled bench-addons-build build-addons build-js-native-api-tes
550550
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
551551
--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
552552
$(TEST_CI_ARGS) $(CI_JS_SUITES) $(CI_NATIVE_SUITES) $(CI_DOC)
553-
out/Release/embedtest 'require("./test/embedding/test-embedding.js")'
553+
$(NODE) ./test/embedding/test-embedding.js
554554
$(info Clean up any leftover processes, error if found.)
555555
ps awwx | grep Release/node | grep -v grep | cat
556556
@PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \

0 commit comments

Comments
 (0)
Please sign in to comment.