better error handling + sql update (#376)

* better error handling + sql update

* do not stop parsing a btc block if encountering a parse error, we may have a parse error partially down the block but we shouldn't halt parsing the rest of the txs for that

* sql update; delete invalid pop basis upon re-org

* revert

Author: ClaytonNorthey92

database/bfgd/postgres/postgres.go

@@ -20,7 +20,7 @@ import (
 )
 
 const (
-	bfgdVersion = 15
+	bfgdVersion = 16
 
 	logLevel = "INFO"
 	verbose  = false

database/bfgd/scripts/0016.sql

@@ -0,0 +1,25 @@
+-- Copyright (c) 2025 Hemi Labs, Inc.
+-- Use of this source code is governed by the MIT License,
+-- which can be found in the LICENSE file.
+
+BEGIN;
+
+UPDATE version SET version = 16;
+
+ALTER TABLE pop_basis DROP CONSTRAINT pop_basis_btc_block_hash_fkey;
+
+-- upon a re-org, set all references to deleted btc block to NULL, then delete those rows via a trigger
+
+ALTER TABLE pop_basis ADD CONSTRAINT pop_basis_btc_block_hash_fkey FOREIGN KEY (btc_block_hash) REFERENCES btc_blocks (hash) ON UPDATE SET NULL;
+
+CREATE FUNCTION clean_pop_basis() RETURNS TRIGGER AS $clean_pop_basis$
+    BEGIN
+        DELETE FROM pop_basis WHERE btc_block_hash IS NULL;
+        RETURN NULL;
+    END;
+$clean_pop_basis$ LANGUAGE plpgsql;
+
+CREATE TRIGGER btc_blocks_clean AFTER INSERT OR UPDATE OR DELETE 
+	ON btc_blocks EXECUTE FUNCTION clean_pop_basis();
+
+COMMIT;

service/bfg/bfg.go

@@ -678,7 +678,8 @@ func (s *Server) processBitcoinBlock(ctx context.Context, height uint64) error {
 
 		publicKeyUncompressed, err := pop.ParsePublicKeyFromSignatureScript(mtx.TxIn[0].SignatureScript)
 		if err != nil {
-			return fmt.Errorf("could not parse signature script: %w", err)
+			log.Errorf("could not parse signature script: %w", err)
+			continue
 		}
 
 		popTxIdFull := []byte{}