Skip to content
This repository was archived by the owner on Mar 20, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hellodword/android-emulator-container-scripts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: google/android-emulator-container-scripts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 6 commits
  • 7 files changed
  • 3 contributors

Commits on Jun 28, 2023

  1. Fixed issue where Envoy wasn't routing requests from localhost:8080 t…

    …o the emulator's gRPC server on port 8554, making it impossible to see, hear, or interact with the emulator using the WebRTC or PNG views.
    KQT2000 committed Jun 28, 2023

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    phansch Phil Hansch
    Copy the full SHA
    7b465e9 View commit details

Commits on Jul 5, 2023

  1. Merge pull request google#345 from KQT2000/master

    Restored Working Build of Android Emulator Container Scripts
    pokowaka authored Jul 5, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    e4cdba1 View commit details

Commits on Nov 10, 2024

  1. Copy the full SHA
    6aa9451 View commit details

Commits on Nov 11, 2024

  1. Merge pull request google#385 from jpcottin/update-docker-py

    Update docker-py dependency because of breakage with request 2.32
    pokowaka authored Nov 11, 2024
    Copy the full SHA
    1892187 View commit details

Commits on Nov 15, 2024

  1. Copy the full SHA
    d6026ce View commit details
  2. Merge pull request google#386 from jpcottin/restore-license

    Adding back the LICENSE
    pokowaka authored Nov 15, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    beef3bc View commit details
Showing with 22 additions and 17 deletions.
  1. +2 −1 js/develop/envoy.yaml
  2. +1 −0 js/docker/docker-compose-build.yaml
  3. +12 −14 js/docker/docker-compose.yaml
  4. +1 −0 js/docker/envoy.yaml
  5. +3 −1 js/src/App.js
  6. +2 −0 js/src/components/emulator_screen.js
  7. +1 −1 pyproject.toml
3 changes: 2 additions & 1 deletion js/develop/envoy.yaml
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ static_resources:
max_stream_duration:
grpc_timeout_header_max: 0s
- match:
prefix: "/android.emulation.control"
prefix: "/android.emulation.control.EmulatorController"
route:
cluster: emulator_service_grpc
timeout: 0s
@@ -105,6 +105,7 @@ static_resources:
connect_timeout: 0.250s
type: STRICT_DNS
lb_policy: ROUND_ROBIN
http2_protocol_options: {}
load_assignment:
cluster_name: emulator_service_grpc
endpoints:
1 change: 1 addition & 0 deletions js/docker/docker-compose-build.yaml
Original file line number Diff line number Diff line change
@@ -15,6 +15,7 @@ services:
- "80:8080"
- "443:8443"
- "8001:8001"
- "8080:8080"
emulator:
image: emulator_emulator:latest
build:
26 changes: 12 additions & 14 deletions js/docker/docker-compose.yaml
Original file line number Diff line number Diff line change
@@ -8,12 +8,11 @@ services:
expose:
- "8080"
- "8001"
- "8443"
ports:
- "80:8080"
- "443:8443"
- "443:8080"
- "8001:8001"

- "8080:8080"
emulator:
image: emulator_emulator:latest
container_name: emulator_emulator
@@ -25,20 +24,19 @@ services:
shm_size: 128M
expose:
- "8554"

jwt_signer:
image: emulator_jwt_signer:latest
container_name: emulator_jwt_signer
networks:
envoymesh:
aliases:
- jwt_signer
expose:
- "8080"
#jwt_signer:
# image: emulator_jwt_signer:latest
# container_name: emulator_jwt_signer
# networks:
# envoymesh:
# aliases:
# - jwt_signer
# expose:
# - "8080"

nginx:
image: emulator_nginx:latest
network_mode: "host"
# network_mode: "host"
container_name: emulator_nginx
networks:
envoymesh:
1 change: 1 addition & 0 deletions js/docker/envoy.yaml
Original file line number Diff line number Diff line change
@@ -105,6 +105,7 @@ static_resources:
connect_timeout: 0.250s
type: STRICT_DNS
lb_policy: ROUND_ROBIN
http2_protocol_options: {}
load_assignment:
cluster_name: emulator_service_grpc
endpoints:
4 changes: 3 additions & 1 deletion js/src/App.js
Original file line number Diff line number Diff line change
@@ -15,7 +15,9 @@ var EMULATOR_GRPC =
"//" +
window.location.hostname +
":" +
window.location.port;
// For some reason, process.env.NODE_ENV either doesn't exist or is equal to "development", causing EMULATOR_GRPC to equal/point to "localhost:" verus "localhost:8080" which is where Envoy is listening for gRPC-Web requests. Hard-coding the appendation of ":8080" as we've done here restores some functionality, as now both the WebRTC and PNG views return a status of "connecting" and the JavaScript console no longer logs any 'JWT is missing' errors. However, the WebRTC and PNG views never return a status of "connected" so video and audio of the emulator cannot be seen/heard.
"8080";
// window.location.port;
if (development) {
EMULATOR_GRPC = window.location.protocol + "//" +
window.location.hostname + ":8080";
2 changes: 2 additions & 0 deletions js/src/components/emulator_screen.js
Original file line number Diff line number Diff line change
@@ -211,6 +211,8 @@ class EmulatorScreen extends React.Component {
volume={volume}
gps={gps}
width={200}
// For some reason, height was not defined. Maybe it was accidentally omitted? Omitting this property will cause the Emulator HTML element that displays the emulator screen not to render since only the width will be rendered.
// height={500}
/>
<p>State: {emuState} </p>
</Container>
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ emu-docker = "emu.emu_docker:main"
[tool.poetry.dependencies]
python = "^3.10"
PyYAML = "^6.0"
docker = "^6.1.1"
docker = "^7.1.0"
tqdm = "^4.65.0"
console-menu = "^0.8.0"
click = "^8.1.3"