Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement load #3

Closed
femtotrader opened this issue Jul 19, 2018 · 4 comments
Closed

Implement load #3

femtotrader opened this issue Jul 19, 2018 · 4 comments

Comments

@femtotrader
Copy link

femtotrader commented Jul 19, 2018

Hello,

Following queryverse/Queryverse.jl#6 (comment)
load function (calling FileIO.load) should be implemented

import FileIO: load

"""
    load(rf::RemoteFile)

Loads the contents of a remote file, downloading file if
it haven't been done previously, reading file from disk
and trying to infer the format from filename and/or magic 
bytes in the file.
"""
function load(rf::RemoteFile)
    if !isfile(rf)
        download(rf)
    end
    load(path(rf))
end

Kind regards

@helgee
Copy link
Owner

helgee commented Jul 23, 2018

Makes sense 👍 Will do...

@helgee helgee closed this as completed in b87f132 Jul 24, 2019
@helgee
Copy link
Owner

helgee commented Jul 24, 2019

Well, that took a while. Sorry 😬

@femtotrader
Copy link
Author

Thanks @helgee
Could you publish a new release with this feature?

@helgee
Copy link
Owner

helgee commented Jul 29, 2019

Under way: JuliaRegistries/General#2346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants