Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clusters list table is visible even if all properties are hidden #2932

Open
DhairyaMajmudar opened this issue Feb 20, 2025 · 1 comment · May be fixed by #2968
Open

Clusters list table is visible even if all properties are hidden #2932

DhairyaMajmudar opened this issue Feb 20, 2025 · 1 comment · May be fixed by #2968
Assignees
@skoeva
Labels
bug Something isn't working frontend Issues related to the frontend

Comments

@DhairyaMajmudar
Copy link
Contributor

Describe the bug

I've obeserved an edge case where a user if switches oof all the properties manually then after the table frame is still visislbe. Other than this if all the field are made hidden using hide all button the whole table get hidden.

To Reproduce

Steps to reproduce the bug:

  • Visit headlamp home page
  • hide all fields manually and then after hide them all using hide all button
  • see the difference.

Environment (please provide info about your environment):

  • Installation type: Linux (Debian)
  • Headlamp Version: Web
  • Other: N/A

Are you able to fix this issue?

Yes

Additional Context

Screencast.from.2025-02-21.01-08-18.webm
@DhairyaMajmudar DhairyaMajmudar added the bug Something isn't working label Feb 20, 2025
@dosubot dosubot bot added the frontend Issues related to the frontend label Feb 20, 2025
@skoeva
Copy link
Contributor

skoeva commented Mar 3, 2025

I can push a fix up for this

@skoeva skoeva self-assigned this Mar 3, 2025
skoeva added a commit that referenced this issue Mar 3, 2025
@skoeva
frontend: Table: Hide rows with hidden columns
96edd8d 
This change ensures that when no columns are visible, the table does not
render any rows, making the behavior consistent with the "hide all"
button.

Fixes: #2932

Signed-off-by: Evangelos Skopelitis <[email protected]>
@skoeva skoeva linked a pull request Mar 3, 2025 that will close this issue
frontend: Hide row actions with hidden columns #2968
Open
4 tasks
@skoeva skoeva linked a pull request Mar 3, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skoeva skoeva

Labels
bug Something isn't working frontend Issues related to the frontend
Projects
Release Plan / Roadmap
Status: Queued
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

frontend: Hide row actions with hidden columns headlamp-k8s/headlamp
2 participants
@skoeva @DhairyaMajmudar