Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bats tests were failing due to uppercase release name #697

Closed
avoidik opened this issue Feb 28, 2022 · 1 comment
Closed

bats tests were failing due to uppercase release name #697

avoidik opened this issue Feb 28, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@avoidik
Copy link
Contributor

avoidik commented Feb 28, 2022

Describe the bug
I wasn't able to complete bats test with make test-bats

To Reproduce
Steps to reproduce the behavior:

  1. Clone repo
  2. Run make test
ok 458 server/standalone-StatefulSet: serviceAccount.name is set
not ok 459 server/standalone-StatefulSet: serviceAccount.name is not set
# (in test file /helm-test/test/unit/server-statefulset.bats, line 1643)
#   `[ "${actual}" = "RELEASE-NAME-vault" ]' failed
# release-name-vault
# /templates/server-statefulset.yaml
# # StatefulSet to run the actual vault server cluster.
# apiVersion: apps/v1
# kind: StatefulSet
# metadata:
#   name: release-name-vault

Expected behavior
Successfully completed tests

Environment

  • Kubernetes version: N/A
    • Distribution or cloud vendor (OpenShift, EKS, GKE, AKS, etc.): N/A
    • Other configuration options or runtime services (istio, etc.): N/A
  • vault-helm version: main

Chart values: N/A

Additional context
Clean environment

@avoidik avoidik added the bug Something isn't working label Feb 28, 2022
@avoidik
Copy link
Contributor Author

avoidik commented Feb 28, 2022

#693

@avoidik avoidik closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant