review feedback

ingressClassName default to "", and test when ingressClassName is not set.

Author: tvoran

test/unit/server-ingress.bats

@@ -143,6 +143,17 @@ load _helpers
   [ "${actual}" = "nginx" ]
 }
 
+@test "server/ingress: ingressClassName is not added by default" {
+  cd `chart_dir`
+
+  local actual=$(helm template \
+      --show-only templates/server-ingress.yaml \
+      --set 'server.ingress.enabled=true' \
+      . | tee /dev/stderr |
+      yq -r '.spec.ingressClassName' | tee /dev/stderr)
+  [ "${actual}" = "null" ]
+}
+
 @test "server/ingress: uses active service when ha by default - yaml" {
   cd `chart_dir`
 

values.yaml

@@ -263,7 +263,7 @@ server:
 
     # Optionally use ingressClassName instead of deprecated annotation.
     # See: https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotation
-    ingressClassName: ~
+    ingressClassName: ""
 
     # When HA mode is enabled and K8s service registration is being used,
     # configure the ingress to point to the Vault active service.