Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providers: Fix init with broken link in plugin_cache_dir #27447

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

Filirom1
Copy link
Contributor

@Filirom1 Filirom1 commented Jan 8, 2021

Hello

Fixes #27445.

Instead of raising and error, it display a warning (TF_LOG=trace) and continue analyzing the next providers.

Cheers
Romain

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 8, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #27447 (5ae5c99) into master (5132abf) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
internal/getproviders/filesystem_search.go 63.20% <0.00%> (-0.51%) ⬇️
internal/providercache/dir.go 73.46% <0.00%> (+6.12%) ⬆️

@Filirom1 Filirom1 marked this pull request as ready for review January 8, 2021 14:32
@pselle pselle changed the title Provisioner: Fix init with broken link in plugin_cache_dir Providers: Fix init with broken link in plugin_cache_dir Jan 11, 2021
@pselle pselle requested a review from a team January 21, 2021 17:41
Copy link
Contributor

@pselle pselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this but I'd like to request a second opinion from another Core team member.

Having run into this today because I'd messed with my settings to replicate the reported issue, I have a better understanding now that the scanning failing init completely, and opaquely, when installing another provider, is difficult and unhelpful. (in this case where I was replicating, it was trying to install an AWS provider, but I'd messed with my plugin-cache dirs for the purpose of recreating this issue, and it was confusingly failing)

Another comment on the initial report #27445 (comment) has a helpful context of how this can happen in real-world cases.

Requesting second opinion because I'm not well-familiar with the plugin installer and cache processes.

@pselle pselle requested a review from a team January 21, 2021 17:45
Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thank you, this has been driving me crazy 😂

@pselle pselle added the 0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Jan 22, 2021
@pselle pselle merged commit 084cec6 into hashicorp:master Jan 22, 2021
@ghost
Copy link

ghost commented Feb 22, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in plugin_cache_dir breaks init
4 participants