-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Providers: Fix init with broken link in plugin_cache_dir #27447
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this but I'd like to request a second opinion from another Core team member.
Having run into this today because I'd messed with my settings to replicate the reported issue, I have a better understanding now that the scanning failing init completely, and opaquely, when installing another provider, is difficult and unhelpful. (in this case where I was replicating, it was trying to install an AWS provider, but I'd messed with my plugin-cache dirs for the purpose of recreating this issue, and it was confusingly failing)
Another comment on the initial report #27445 (comment) has a helpful context of how this can happen in real-world cases.
Requesting second opinion because I'm not well-familiar with the plugin installer and cache processes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thank you, this has been driving me crazy 😂
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Hello
Fixes #27445.
Instead of raising and error, it display a warning (TF_LOG=trace) and continue analyzing the next providers.
Cheers
Romain