Correctly compare unordered sets of marks #27318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
|
This will need to be backported to 0.14, but must be done manually due to significant refactoring in master. |
When comparing marks for values during plan and apply, we need to ensure the order of the marked paths is consistent.
This plan would occasionally show changes when there weren't any due to the sensitive marks being compared incorrectly.
jbardin
force-pushed
the
jbardin/path-marks
branch
from
c062965 to
1309b36
Compare
pselle
approved these changes
Dec 17, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing marks for values during plan and apply, we need to ensure the order of the marked paths is consistent. Since the marks themselves were not ordered, we would occasionally turn
NoOpplans toUpdatewhen there was no change to the values or sensitivity. This could then cascade through the plan causing numerous changes to appear with no clear cause.Fixes #27287