Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmark values in count before go conversion #27238

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Dec 10, 2020

When evaluating count values, we need to unmark the cty value before passing the value for conversion into a go int value.

This PR adds a test file/some coverage for the evaluateCountExpression function, but selfishly limits this addition to the basic level plus adding a test case specific to this marking.

When evaluating count values, we need to unmark
the cty value before passing the value for conversion
into a go int value.
@pselle pselle requested a review from a team December 10, 2020 16:42
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #27238 (0d586fd) into master (30126ba) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
terraform/eval_count.go 68.42% <100.00%> (+0.56%) ⬆️
dag/marshal.go 61.90% <0.00%> (-1.59%) ⬇️
terraform/node_resource_apply_instance.go 55.46% <0.00%> (+2.52%) ⬆️

@pselle pselle added the 0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Dec 10, 2020
@ghost
Copy link

ghost commented Jan 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants