Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix file mode on lock file #27205

Merged
merged 1 commit into from
Dec 18, 2020
Merged

fix file mode on lock file #27205

merged 1 commit into from
Dec 18, 2020

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Dec 8, 2020

Signed-off-by: Anthony Sottile [email protected]

Resolves #27116

@asottile
fix file mode on lock file
b852915 
Signed-off-by: Anthony Sottile <[email protected]>
@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #27205 (b852915) into master (30126ba) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
internal/depsfile/locks_file.go 77.22% <100.00%> (ø)
internal/providercache/dir.go 67.34% <0.00%> (-6.13%) ⬇️
terraform/node_resource_plan.go 96.11% <0.00%> (-1.95%) ⬇️
dag/marshal.go 61.90% <0.00%> (-1.59%) ⬇️
terraform/evaluate.go 52.89% <0.00%> (-0.42%) ⬇️
terraform/node_resource_apply_instance.go 55.46% <0.00%> (+2.52%) ⬆️

@alisdair alisdair requested a review from a team December 11, 2020 15:40
mildwonkey
mildwonkey approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for submitting this, @asottile ! I appreciate the extended test ❤️

@mildwonkey mildwonkey merged commit 8cd72e5 into hashicorp:master Dec 18, 2020
@asottile asottile deleted the non_executable_lock_file branch December 18, 2020 16:53
@jbardin jbardin added the 0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Jan 7, 2021
jbardin pushed a commit that referenced this pull request Jan 7, 2021
@asottile @jbardin
fix file mode on lock file (#27205)
a2c3216 
Signed-off-by: Anthony Sottile <[email protected]>
@jbardin jbardin mentioned this pull request Jan 7, 2021
Merged
jbardin added a commit that referenced this pull request Jan 7, 2021
@jbardin
Merge pull request #27436 from hashicorp/backport/27205
ec5d3a4 
0.14 backport of #27205
@ghost
Copy link

ghost commented Jan 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mildwonkey mildwonkey mildwonkey approved these changes

Assignees
No one assigned
Labels
0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency lock file is world-writable, does not respect umask setting
3 participants
@asottile @mildwonkey @jbardin