Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-getter to v1.5.1 with support for vhost style S3 paths #26914

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

picatz
Copy link
Contributor

@picatz picatz commented Nov 13, 2020

Aims to fix #24656 and related to hashicorp/go-getter#263

@picatz picatz added bug dependencies Auto-pinning labels Nov 13, 2020
@picatz picatz requested a review from a team November 13, 2020 16:15
@picatz picatz self-assigned this Nov 13, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #26914 (63cc597) into master (be26315) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
terraform/node_resource_plan.go 95.28% <0.00%> (-1.89%) ⬇️
dag/marshal.go 53.42% <0.00%> (-1.37%) ⬇️

Copy link
Contributor

@pselle pselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (one grammar nit) but holding on merge depending on whether we want to have this in 0.14.0 or 0.14.1 Deciding to merge this for 0.14.0 considering the deprecation of path-style.

@pselle pselle added the 0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Nov 13, 2020
Co-authored-by: Pam Selle <[email protected]>
@ghost
Copy link

ghost commented Dec 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 14, 2020
@pselle pselle deleted the update-go-getter branch March 4, 2021 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged bug dependencies Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for loading modules with S3 virtual hosted-style access
2 participants