deps: bump go-cty version #26079
Merged
deps: bump go-cty version #26079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-cty v1.6.0 fixes a panic in the `element` function. Closes #25775
pselle
approved these changes
Sep 1, 2020
|
Oops, I shouldn't have approved, there's a bunch of test failures. Maybe related to some of the removed packages? |
|
sorry @pselle , I should not have requested review yet! The failures appear to be linked to the go-cty bump but I'm not sure yet. Let me un-request review, sorry to everyone for the noise. |
Codecov Report
|
alisdair
approved these changes
Sep 3, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-cty v1.6.1 fixes a panic in the
elementfunction when called with a negative offset.I am targeting master and will not backport to 0.13 yet; there are enough changes to cty's handling of sets in this upgrade that we'd like to hold off backporting until (ideally) a 0.14.0 alpha release.
The panic is tested in the go-cty library (I know, I wrote it) so I didn't add anything here, but here's proof: