-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: azurerm_media_streaming_endpoint
#9537
New resource: azurerm_media_streaming_endpoint
#9537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez - i've given this a review and left some comments inline to address
azurerm/internal/services/media/media_streaming_endpoint_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_streaming_endpoint_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/parse/media_streaming_endpoint_test.go
Outdated
Show resolved
Hide resolved
Thank you @katbyte I did the suggested changes in this PR too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jcanizalez
Thanks for pushing those changes :)
Taking a look through this is looking good - if we can work through the comments and the tests pass then this should be otherwise good to go 👍
Thanks!
azurerm/internal/services/media/media_streaming_endpoint_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_streaming_endpoint_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_streaming_endpoint_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_streaming_endpoint_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_streaming_endpoint_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_streaming_endpoint_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/media_streaming_endpoint_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/tests/media_streaming_endpoint_resource_test.go
Show resolved
Hide resolved
Thank you @tombuildsstuff very helpful feedback, so I already applied it. PR it's ready if you want to take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez - this LGTM 👍
This has been released in version 2.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.41.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Including the support for new resource azurerm_media_streaming_endpoint. Was required to update the API version to new version 2020-05-01, but I have already validated that the Acceptance test still works. This PR resolves #6597
Checked: