Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_media_streaming_endpoint #9537

Merged
merged 11 commits into from
Dec 10, 2020
Merged

New resource: azurerm_media_streaming_endpoint #9537

merged 11 commits into from
Dec 10, 2020

Conversation

jcanizalez
Copy link
Contributor

Including the support for new resource azurerm_media_streaming_endpoint. Was required to update the API version to new version 2020-05-01, but I have already validated that the Acceptance test still works. This PR resolves #6597

Checked:

  • Update Documentation
  • Add new Acceptance Test and verified that the tests pass successfully
  • Check linting

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - i've given this a review and left some comments inline to address

@jcanizalez
Copy link
Contributor Author

Thank you @katbyte I did the suggested changes in this PR too

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jcanizalez

Thanks for pushing those changes :)

Taking a look through this is looking good - if we can work through the comments and the tests pass then this should be otherwise good to go 👍

Thanks!

@jcanizalez
Copy link
Contributor Author

Thank you @tombuildsstuff very helpful feedback, so I already applied it. PR it's ready if you want to take a look

@ghost ghost removed the waiting-response label Dec 10, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - this LGTM 👍

@katbyte katbyte added this to the v2.41.0 milestone Dec 10, 2020
@katbyte katbyte merged commit b0a1877 into hashicorp:master Dec 10, 2020
katbyte added a commit that referenced this pull request Dec 10, 2020
@jcanizalez jcanizalez deleted the azurerm_media_streaming_endpoint branch December 14, 2020 16:12
@ghost
Copy link

ghost commented Dec 17, 2020

This has been released in version 2.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.41.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Streaming Endpoints
3 participants