New resource/data source azurerm_vmware_private_cloud

[yupwei68]

Partial fix:#9283

resource:
=== RUN TestAccAzureRMavsPrivateCloud_basic
--- PASS: TestAccAzureRMavsPrivateCloud_basic (10846.50s)
=== RUN TestAccAzureRMavsPrivateCloud_requiresImport
--- PASS: TestAccAzureRMavsPrivateCloud_requiresImport (12860.45s)
=== RUN TestAccAzureRMavsPrivateCloud_complete
--- PASS: TestAccAzureRMavsPrivateCloud_complete (13994.93s)
=== RUN TestAccAzureRMavsPrivateCloud_update
--- PASS: TestAccAzureRMavsPrivateCloud_update (26093.55s)

data source:
=== RUN TestAccDataSourceAzureRMavsPrivateCloud_basic
=== PAUSE TestAccDataSourceAzureRMavsPrivateCloud_basic
=== CONT TestAccDataSourceAzureRMavsPrivateCloud_basic
--- PASS: TestAccDataSourceAzureRMavsPrivateCloud_basic (11827.09s)

[katbyte]

Thanks @yupwei68 - i've given this a quick first review and left some comments inline

[katbyte]

Why is this case insensitive?

[yupwei68]

The service accepts both cases. It returns in lowercase. Would we force it to be lowercase?

[yupwei68]

I've forced to be lowercase.

[katbyte]

THanks @yupwei68 - overall looks good, once the comments are addressed will be good ot merge

[yupwei68]

@katbyte TC has passed.

[katbyte]

Thanks @yupwei68, i've left some mostly minor comments inline - this should be good to merge once address thou!

[yupwei68]

THanks @katbyte Please continue reviewing.

[katbyte]

Thanks @yupwei68 - LGTM 👍

[ghost]

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!