-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSSQL: working around a breaking change in the MSSQL API #8975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tombuildsstuff - LGTM 👍
Hi, Tom! Thanks for this fix :) When do you think will version 2.33 of AzureRM be finally published? |
@dpalat approximate dates are on the milestones page: https://github.com/terraform-providers/terraform-provider-azurerm/milestones |
MSSQL tests look fine 👍 |
This has been released in version 2.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.33.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR works around #8915 - which describes a breaking upstream API change tracked in Azure/azure-rest-api-specs#11271
Whilst we've got a Microsoft Support and an ICM Ticket tracking this, unfortunately this'll be several days until the breaking API change is resolved, as the Service Team have opted to release the current API version to all regions, then fix the bug, rather than reverting this change.
The Service Team have confirmed that it's possible to workaround this by sending an additional field in the request - setting
isAzureMonitorTargetEnabled
totrue
- as such this PR forces this on at this time, exposing this as a user configurable field is left as a future exercise (since we believe this should only be temporary until the API is fixed and can ultimately be reverted).Tests pass for the Legacy SQL Resources (ignoring an unrelated/known issue):
Tests are in progress for the MSSQL Resources:
[TODO: screenshot when done]
Fixes #8915