Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSSQL: working around a breaking change in the MSSQL API #8975

Merged
merged 7 commits into from
Oct 22, 2020

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Oct 21, 2020

This PR works around #8915 - which describes a breaking upstream API change tracked in Azure/azure-rest-api-specs#11271

Whilst we've got a Microsoft Support and an ICM Ticket tracking this, unfortunately this'll be several days until the breaking API change is resolved, as the Service Team have opted to release the current API version to all regions, then fix the bug, rather than reverting this change.

The Service Team have confirmed that it's possible to workaround this by sending an additional field in the request - setting isAzureMonitorTargetEnabled to true - as such this PR forces this on at this time, exposing this as a user configurable field is left as a future exercise (since we believe this should only be temporary until the API is fixed and can ultimately be reverted).

Tests pass for the Legacy SQL Resources (ignoring an unrelated/known issue):

Screenshot 2020-10-21 at 19 57 43

Tests are in progress for the MSSQL Resources:

[TODO: screenshot when done]

Fixes #8915

@tombuildsstuff tombuildsstuff added bug service/mssql Microsoft SQL Server upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Oct 21, 2020
@tombuildsstuff tombuildsstuff added this to the v2.33.0 milestone Oct 21, 2020
@tombuildsstuff tombuildsstuff requested a review from a team October 21, 2020 17:59
@ghost ghost added the size/XS label Oct 21, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - LGTM 👍

@dpalat
Copy link

dpalat commented Oct 22, 2020

Hi, Tom! Thanks for this fix :) When do you think will version 2.33 of AzureRM be finally published?

@tombuildsstuff
Copy link
Contributor Author

@dpalat approximate dates are on the milestones page: https://github.com/terraform-providers/terraform-provider-azurerm/milestones

@ghost ghost added size/S and removed size/XS labels Oct 22, 2020
@tombuildsstuff
Copy link
Contributor Author

MSSQL tests look fine 👍

@tombuildsstuff tombuildsstuff merged commit 8c07ec7 into master Oct 22, 2020
@tombuildsstuff tombuildsstuff deleted the b/workaround-broken-mssql-api branch October 22, 2020 12:08
tombuildsstuff added a commit that referenced this pull request Oct 22, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 2.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.33.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/mssql Microsoft SQL Server size/S upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mssql_server: breaking change in the azure api
3 participants