New data source: azurerm_mysql_server #8787
Conversation
Lucretius
changed the title
There was a problem hiding this comment.
Hi @Lucretius, thanks for this PR! I have some minor suggestions below, including a way to dry out the tests a bit. If we can fix these up, this looks good to merge.
azurerm/internal/services/mysql/tests/mysql_server_data_source_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Bamford <[email protected]>
Co-authored-by: Tom Bamford <[email protected]>
Co-authored-by: Tom Bamford <[email protected]>
Co-authored-by: Tom Bamford <[email protected]>
Co-authored-by: Tom Bamford <[email protected]>
Co-authored-by: Tom Bamford <[email protected]>
…_test.go Co-authored-by: Tom Bamford <[email protected]>
Co-authored-by: Tom Bamford <[email protected]>
Co-authored-by: Tom Bamford <[email protected]>
Co-authored-by: Tom Bamford <[email protected]>
|
Thanks @manicminer - I've accepted all the suggestions, thanks for that (wish Github let me accept them all in one commit instead of one at a time). Also gives me a good idea of what to watch out for in the future. |
|
@Lucretius great! could you update the other tests too? ( |
There was a problem hiding this comment.
@Lucretius Thanks for making those changes. When running the tests, I spotted some other issues that I missed earlier.
azurerm/internal/services/mysql/tests/mysql_server_data_source_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mysql/tests/mysql_server_data_source_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mysql/tests/mysql_server_data_source_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mysql/tests/mysql_server_data_source_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/mysql/tests/mysql_server_data_source_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Bamford <[email protected]>
|
Thanks again for clarifying the issues with the tests, sorry there were so many! I'll keep them in mind in future PRs. |
manicminer
force-pushed
the
data-source-mssql-server
branch
from
9413944 to
7013a06
Compare
manicminer
force-pushed
the
data-source-mssql-server
branch
from
7013a06 to
48624f9
Compare
|
@Lucretius I pushed some additional minor test fixes (some of the configs were pointing at the wrong test config funcs and some attribute check values didn't match the configuration). The tests now pass. Thanks again!
|
|
This has been released in version 2.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.32.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Resolves #4924
This is not a resource I have ever used, but I followed along the existing resource to build out the data source, and reused the tests (adding in the data source at the end of each) and checking the values.