-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new resource azurerm_security_center_automation for automation and data export #8781
Conversation
This resolves a bug in the Azure SDK for Go Link to issue Azure/azure-sdk-for-go#12634
Note the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @benc-uk
Thanks for this PR, looking really good so far, some comments and questions below.
Also, following the thread it sounds like we should wait for SDK 47 before taking this forward so the overrides and change to go.mod
can be removed? I'll take a look at that asap.
azurerm/internal/services/securitycenter/resource_arm_security_center_automation.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/securitycenter/resource_arm_security_center_automation.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/securitycenter/resource_arm_security_center_automation.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/securitycenter/resource_arm_security_center_automation.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/securitycenter/resource_arm_security_center_automation.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/securitycenter/resource_arm_security_center_automation.go
Show resolved
Hide resolved
azurerm/internal/services/securitycenter/resource_arm_security_center_automation.go
Show resolved
Hide resolved
azurerm/internal/services/securitycenter/resource_arm_security_center_automation.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/securitycenter/resource_arm_security_center_automation.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/securitycenter/resource_arm_security_center_automation.go
Show resolved
Hide resolved
This resolves a bug in the Azure SDK for Go Link to issue Azure/azure-sdk-for-go#12634
Yes I think waiting for v47 of the SDK is better and then I could remove my workaround from the azuresdkhacks package, there's a PR for getting v47 added in #8865 |
Hi @jackofallops I know we were waiting on updating to the Go SDK v47+ before merging this, has there been any progress on that front? |
Hi @benc-uk - Yes, we've had some churn on the SDK, it's now at |
Thanks, I just spotted the SDK had been upgraded so I'm going to re-test my branch against the latest master and with the sdkhacks workaround removed |
Now using the normal SDK client
@jackofallops - I think we're in decent shape, I've removed the hack workaround and it all seems good & all my acceptance tests pass |
This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.37.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Adds new resource for configuring export of Security Center alerts and recommendations to a range of destinations
This is done via what is referred to in Security Center as "workflow automation" and "continuous export"
Fixes #8611
Example resource to send alerts to a Logic App
This resource supports three types of destination in the action, Logic App as shown above, but also Log Analytics and Event Hubs
Notes.
source
,action
blocks can be specified multiple timesaction.type
must be one ofLogicApp
,EventHub
orLogAnalytics
action.connection_string
argument is only required when type isEventHub
, this must be a valid Event Hub connection stringaction.trigger_url
argument is only required when type isLogicApp
, this must be a valid URL, and should be the callback POST URL shown in the Logic App portal trigger historyscopes
argument is an list of resource or subscription ids (at least one)rule_set
andrule
block of anaction
can also be configured multiple times, and anaction
can be created without anyrule_set
(s)source.event_source
must be one ofAlerts
,Assessments
orSubAssessments
When setting up rules, the schema of the source data needs to be known in order to set the
property_path
&property_type
fields. The schema for Security Center alerts can be found here. The schema for Assessments & SubAssessments seems undocumented, but can be reverse engineered by configuration via the portal and then inspection with the APIaz rest --url "https://management.azure.com/subscriptions/_subid_/resourceGroups/_rg_/providers/Microsoft.Security/automations/_name_?api-version=2019-01-01-preview"