new resource: azurerm_kusto_iothub_data_connection

[njuCZ]

refactor kusto RP and add new resource

[katbyte]

Thanks @njuCZ - overall this looks good but could we get a complete and update test? thanks!

[katbyte]

Could we add a complete test which sets all optional properties and then an update test that goes basic -> complete -> basic?

[njuCZ]

@katbyte sorry for late reply. complete test is hard for this resource, because the optional fields "table_name", "mapping_rule_name" are kusto RP data plane resource. Fow now, we could not create them through terraform. and I found existing resource azurerm_kusto_eventhub_data_connection keeps these fields and no complete acctest.

Do you think we would better delete these fields or just keep them and no test?

[katbyte]

@njuCZ - can we just delete the properties we cannot test and leave the rest for now? thanks

[njuCZ]

@katbyte Thanks for your advice, I have deleted these fields. Please have a look again when free.

[njuCZ]

just rebased the latest master branch and resolve conflicts

[katbyte]

@njuCZ - this is failing to build with:

[15:38:08]	[Step 4/5] ./kusto_cluster_customer_managed_key_resource.go:11:2: imported and not used: "github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
[15:38:08]	[Step 4/5] ./kusto_eventhub_data_connection_resource.go:16:2: validate redeclared as imported package name
[15:38:08]	[Step 4/5] 	previous declaration at ./kusto_eventhub_data_connection_resource.go:14:2
[15:38:08]	[Step 4/5] ./kusto_eventhub_data_connection_resource.go:90:19: undefined: "github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto/validate".ValidateEventHubConsumerName
[15:39:30]	[Step 4/5] Process exited with code 2
[15:39:30]	[Step 4/5] Process exited with code 2 (Step: Compile Test Binary (Command Line))
[15:39:30]	[Step 4/5] Step Compile Test Binary (Command Line) failed
[15:39:30]	[Step 4/5] Error message is logged

[njuCZ]

@katbyte I have rebased this PR, now it could build successfully and acctest could pass.

[katbyte]

Thanks @njuCZ - LGTM 👍

[ghost]

This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.49.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!