add support for sku_name and trace for azurerm_spring_cloud_service
#7531
Conversation
njuCZ
commented
Jun 30, 2020
•
njuCZ
commented
There was a problem hiding this comment.
hi @njuCZ
Thanks for this PR - I've taken a look through and left some comments inline but this is off to a good start. Rather than having a field for enabled/disabled - we can instead infer this field from the presence of the trace block - which means that removing this block will allow you to disable this functionality.
Thanks!
azurerm/internal/services/appplatform/spring_cloud_service_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/appplatform/spring_cloud_service_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/appplatform/spring_cloud_service_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/appplatform/spring_cloud_service_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/appplatform/tests/spring_cloud_service_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/appplatform/spring_cloud_service_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/appplatform/spring_cloud_service_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/appplatform/spring_cloud_service_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/appplatform/spring_cloud_service_resource.go
Outdated
Show resolved
Hide resolved
|
@tombuildsstuff thanks for your kindly suggestion. I have modified this PR and passed the acctest, could you please have a look again? |
|
@njuCZ I've re-triggered Travis so that should go green, looks like a connection error |
|
Tests pass:
|
|
This has been released in version 2.17.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.17.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
