-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Allow updating Analysis Services Server when paused #6786
[Enhancement] Allow updating Analysis Services Server when paused #6786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @r0bnet
Thanks for this PR - taking a look through this is looking good - if we can fix up the minor comments and add an acceptance test then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/analysisservices/analysis_services_server_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/analysisservices/analysis_services_server_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/analysisservices/analysis_services_server_resource.go
Outdated
Show resolved
Hide resolved
@tombuildsstuff added an acceptance test and fixed your comments. |
azurerm/internal/services/analysisservices/analysis_services_server_resource.go
Show resolved
Hide resolved
azurerm/internal/services/analysisservices/tests/analysis_services_server_resource_test.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This has been released in version 2.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.9.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR checks if the Analysis Services Server is paused when it's going to be updated and will start it before. It will also suspend it again afterwards if needed.
Before it was unable to update a paused Analysis Services Server.