[azurerm_private_link_service] Nil check additional properties #6504
Conversation
| if err := d.Set("auto_approval_subscription_ids", utils.FlattenStringSlice(props.AutoApproval.Subscriptions)); err != nil { | ||
| return fmt.Errorf("Error setting `auto_approval_subscription_ids`: %+v", err) | ||
| if autoApproval := props.AutoApproval; autoApproval != nil { | ||
| if autoApproval.Subscriptions != nil { |
There was a problem hiding this comment.
we can remove this inner nil-check since the flatten func will handle returning an empty array if this is nil
| if err := d.Set("visibility_subscription_ids", utils.FlattenStringSlice(props.Visibility.Subscriptions)); err != nil { | ||
| return fmt.Errorf("Error setting `visibility_subscription_ids`: %+v", err) | ||
| if visibility := props.Visibility; visibility != nil { | ||
| if visibility.Subscriptions != nil { |
There was a problem hiding this comment.
we can remove this inner nil-check since the flatten func will handle returning an empty array if this is nil
|
LGTM - thanks for this @hbuckle |
|
This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.7.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
We noticed the API doesn't always return these properties which was causing a crash