-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_network_interface: expose internal_domain_name_suffix #6455
azurerm_network_interface: expose internal_domain_name_suffix #6455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bailsman, thanks for the PR. overall this looks great but we're missing some doc updates. Whats those are done this should be good to merge!
After a network interface has been created in a subnet, Azure assigns it an internal domain name and exposes this as a property. The suffix looks something like this: tcjzv0sul21rwyt5qe31ylgpgo.ax.internal.cloudapp.net Servers can reach each other internally at, for example: server0.tcjzv0sul21rwyt5qe31ylgpgo.ax.internal.cloudapp.net This change exposes the azure provided internal_domain_name_suffix in terraform
158ae1c
to
628df55
Compare
Oops. I force pushed and may have disappeared your comments, so now I'm not sure what changes you requested. I added a line to the resource documentation explaining the attribute that is now exposed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bailsman! LGTM now 👍
This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.6.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
After a network interface has been created in a subnet, Azure assigns it
an internal domain name and exposes this as a property.
The suffix looks something like this:
tcjzv0sul21rwyt5qe31ylgpgo.ax.internal.cloudapp.net
Servers can reach each other internally at, for example:
server0.tcjzv0sul21rwyt5qe31ylgpgo.ax.internal.cloudapp.net
This change exposes the azure provided internal_domain_name_suffix in terraform.
This is useful, for example, when creating a self-signed server certificate to be used internally, if you do want the common name to match the hostname that the other server connects on.