Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_machine_scale_set need ability to override default scale-in policy #5738

Closed
jpveritone opened this issue Feb 13, 2020 · 2 comments · Fixed by #5391
Closed

Comments

@jpveritone
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Affected Resource(s)

  • azurerm_virtual_machine_scale_set

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key: https://keybase.io/hashicorp

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000

We're using terraform v0.11.3 along with Azure terraform provider v1.41.0.
We use https://www.terraform.io/docs/providers/azurerm/r/virtual_machine_scale_set.html to create our VMSS. The problem is terraform is not giving option or way to change the VMSS default scale-in policy, Refer to https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-scale-in-policy.
As a result when we scale in it will remove the VM with highest ID, thus newer ones, whereas we want to remove older one which would be the policy named OldestVM I can do this via Azure CLI or fro Azure Portal but cannot find a way to do via terraform.
Are there any plans to fix this in terraform provider?

@ArcturusZhang
Copy link
Contributor

I have already implemented this feature in this PR.
But this feature only updates the 2.0 vmss resources, azurerm_linux_virtual_machine_scale_set and azurerm_windows_virtual_machine_scale_set, the legacy vmss resource azurerm_virtual_machine_scale_set will not receive any further features.

@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants