Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure defined azurerm_storage_accounts tag character limits not handled #1511

Closed
philbal611 opened this issue Jul 6, 2018 · 1 comment · Fixed by #1524
Closed

Azure defined azurerm_storage_accounts tag character limits not handled #1511

philbal611 opened this issue Jul 6, 2018 · 1 comment · Fixed by #1524

Comments

@philbal611
Copy link
Contributor

philbal611 commented Jul 6, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v0.11.7

Affected Resource(s)

  • azurerm_storage_account

Terraform Configuration Files

provider "azurerm" {}

resource "azurerm_resource_group" "test-main" {
    name     = "${var.resource_group_name}"
    location = "centralus"
}

resource "azurerm_storage_account" "test" {
    name                      = "testsa"
    resource_group_name       = "${var.resource_group_name}"
    location                  = "${azurerm_resource_group.test-main.location}"
    account_tier              = "Standard"
    account_replication_type  = "LRS"
    enable_https_traffic_only = true

    tags {
 tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag1tag12 = "129characters"
  }
}

Debug Output

None (missing)

Expected Behavior

According to Azure documentation, all tag names are limited to 512 characters. Terraform catches this before planning. However, storage_accounts are a special case where they are limited to 128 characters. When a storage account tag is planned with 129 characters, the plan should fail.

Actual Behavior

The plan ran successfully.

Steps to Reproduce

  1. Build configuration with storage account having 129 character tag name
  2. Run terraform plan

References

https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/tags.go
512 character tag names, 256 character tag values, and max 15 tags are handled. Storage accounts require this support

  • #0000
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants