Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service and azurerm_function_app - Fix broken ip_restrictions and scm_ip_restrictions updates #11170

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

jackofallops
Copy link
Member

The subnet_id property, deprecated in provider version 2.23.0, has been removed to resolve a bug in updating IP Restrictions and SCM IP Restrictions created by that deprecation. The property name virtual_network_subnet_id is a direct replacement.

Closes #8768
Supersedes #10843

Affects:
azurerm_app_service
azurerm_function_app
Data Source: azurerm_app_service
Data Source: azurerm_function_app

@jackofallops jackofallops added this to the v2.55.0 milestone Mar 31, 2021
@jackofallops jackofallops requested a review from a team March 31, 2021 11:29
@jackofallops jackofallops self-assigned this Mar 31, 2021
@ghost ghost added the size/XL label Mar 31, 2021
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops wrong review

@mbfrahry mbfrahry dismissed their stale review March 31, 2021 22:14

Wrong review!

@ghost
Copy link

ghost commented Apr 9, 2021

This has been released in version 2.55.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.55.0"
}
# ... other configuration ...

@katbyte katbyte modified the milestones: v2.55.0, v2.56.0 Apr 9, 2021
@jackofallops jackofallops requested a review from a team April 12, 2021 10:38
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackofallops - LGTM 👍

@jackofallops
Copy link
Member Author

Tests looking fine (failures unrelated to change)

image

@katbyte katbyte merged commit 366201e into master Apr 15, 2021
@katbyte katbyte deleted the b/app-service-iprestrictions branch April 15, 2021 21:27
katbyte added a commit that referenced this pull request Apr 15, 2021
@ghost
Copy link

ghost commented Apr 16, 2021

This has been released in version 2.56.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.56.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 16, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_app_service ip_restriction doesn't remove subnet_id when unset
3 participants