Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create private dns zone group if configuration has changes #10559

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Only create private dns zone group if configuration has changes #10559

merged 1 commit into from
Feb 17, 2021

Conversation

brandonmbanks
Copy link
Contributor

Fixes #10556

@ghost ghost added the size/XS label Feb 12, 2021
@brandonmbanks brandonmbanks changed the title Only create if private_dns_zone_group has changes Only create private dns zone group if configuration has changes Feb 12, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @brandonmbanks

@tombuildsstuff tombuildsstuff added this to the v2.48.0 milestone Feb 17, 2021
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2021-02-17 at 14 25 05

@tombuildsstuff tombuildsstuff merged commit 6b307ca into hashicorp:master Feb 17, 2021
tombuildsstuff added a commit that referenced this pull request Feb 17, 2021
@brandonmbanks brandonmbanks deleted the private-endpoint-private-dns-create-fix branch February 17, 2021 15:28
@ghost
Copy link

ghost commented Feb 18, 2021

This has been released in version 2.48.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.48.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private endpoint update fails if no permissions to Private DNS Zone
2 participants