-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_storage_data_lake_gen2_filesystem_resource: do not set/retrieve ACLs when HNS is not Enabled #10470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @njuCZ
Thanks for this PR - taking a look through I've left some comments inline, but if we can fix those up then we should be able to take another look.
Thanks!
azurerm/internal/services/storage/storage_data_lake_gen2_filesystem_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/storage_data_lake_gen2_filesystem_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/storage_data_lake_gen2_filesystem_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/storage_data_lake_gen2_filesystem_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/storage/storage_data_lake_gen2_filesystem_resource_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @njuCZ - LGTM 👍
This has been released in version 2.46.1 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.46.1"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
all synapse related test case are failed because of getting acl for storage data lake gen2 resource.
according to https://docs.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-access-control#do-i-have-to-enable-support-for-acls
acl is enabled when Hierarchical Namespace (HNS) feature in storage account is turned ON.
After testing, when Hierarchical Namespace feature is disabled in storage account, the getAcl rest api will report error, which cause all tc in synapse fails