Add enable_host_encryption to AKS node pool resources
#10398
Conversation
jackbatzner
changed the title
enable_host_encryption to AKS resourcesenable_host_encryption to AKS node pool resources
jackbatzner
changed the title
enable_host_encryption to AKS node pool resourcesenable_host_encryption to AKS node pool resources
There was a problem hiding this comment.
hey @Brunhil
Thanks for this PR.
Taking a look through here this mostly LGTM - if we can fix up the minor comments and the tests pass then this should otherwise be good to merge 👍
Thanks!
| @@ -73,6 +73,8 @@ The following arguments are supported: | |||
|
|
|||
| * `enable_auto_scaling` - (Optional) Whether to enable [auto-scaler](https://docs.microsoft.com/en-us/azure/aks/cluster-autoscaler). Defaults to `false`. | |||
|
|
|||
| * `enable_host_encryption` - (Optional) Whether to enable host encryption or not. Defaults to `false`. | |||
There was a problem hiding this comment.
could we make this:
| * `enable_host_encryption` - (Optional) Whether to enable host encryption or not. Defaults to `false`. | |
| * `enable_host_encryption` - (Optional) Should the nodes in this Node Pool have host encryption enabled? Defaults to `false`. |
| @@ -229,6 +229,8 @@ A `default_node_pool` block supports the following: | |||
|
|
|||
| -> **NOTE:** If you're using AutoScaling, you may wish to use [Terraform's `ignore_changes` functionality](https://www.terraform.io/docs/configuration/resources.html#ignore_changes) to ignore changes to the `node_count` field. | |||
|
|
|||
| * `enable_host_encryption` - (Optional) Should the nodes in this Node Pool have host encryption enabled? Defaults to `false`. | |||
There was a problem hiding this comment.
can we make this:
| * `enable_host_encryption` - (Optional) Should the nodes in this Node Pool have host encryption enabled? Defaults to `false`. | |
| * `enable_host_encryption` - (Optional) Should the nodes in the Default Node Pool have host encryption enabled? Defaults to `false`. |
|
The new tests pass:
|
|
Tests pass for the "basic" tests too:
|
|
Thank you @Brunhil and @tombuildsstuff ! |
|
This has been released in version 2.46.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.46.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Resolves #10387 by adding
enable_host_encryptionflag to theazurerm_kubernetes_clusterandazurerm_kubernetes_cluster_node_poolresources.