synapse_workspace_resource support azure_devops_repo, and github_repo

[allantargino]

fix #10091

It follows the same interface for source control from azurerm_data_factory, except for:

• tenant_id is not supported by current Synapse go SDK.
• azure_devops_repo instead of vsts_configuration, since the official documentation is using the term Azure DevOps.
• github_repo instead of github_configuration

[allantargino]

Hi @tombuildsstuff @katbyte, I would appreciate your review 😄

[katbyte]

Hey @allantargino - just ran the tests for this but i am getting this error:

------- Stdout: -------
=== RUN   TestAccSynapseWorkspace_azdo
=== PAUSE TestAccSynapseWorkspace_azdo
=== CONT  TestAccSynapseWorkspace_azdo
    testing.go:684: Step 0 error: errors during apply:
        
        Error: Error retrieving ACLs for Root path in File System "acctest-210128063831382385" in Storage Account "acctestacc7j0nw": datalakestore.Client#GetProperties: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: error response cannot be parsed: "" error: EOF
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test098443127/main.tf line 21:
          (source code not available)
        
        
    testing.go:745: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: errors during refresh: Error retrieving ACLs for Root path in File System "acctest-210128063831382385" in Storage Account "acctestacc7j0nw": datalakestore.Client#GetProperties: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: error response cannot be parsed: "" error: EOF
        
        State: <nil>
--- FAIL: TestAccSynapseWorkspace_azdo (51.03s)
FAIL

do you get this error?

[allantargino]

Hi @katbyte,
I am not getting this error, I just ran the tests again:

Looking at the error message, the 403 on the data lake is usually a permission issue. My service principal is owner of my Azure subscription. Do you get this error when running TestAccSynapseWorkspace_basic too?

[katbyte]

Looks like something changed on the 26th and all our tests started to fail for synapse with that error, will have to look into whats going on with our subscription

[njuCZ]

@katbyte recently I am doing another task about Synapse and also found this issue. It seems it's casued by retrieving ACL rest api.
the response status code is 403, which shows the permission is not enough. After I assign the Storage Blob Data Contributor role and test again, it report 400 this time. It seems it's by design when the hns feature is disabled.
I have submit a PR to fix this problem: #10470

[katbyte]

@allantargino - tests are fixed now, just one comment about the schema and this should be good to merge

[allantargino]

Thanks @katbyte, I applied the suggested changes.

[katbyte]

Thanks @allantargino - this LGTM now 👍

[ghost]

This has been released in version 2.48.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.48.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!