Default Affinity Settings - Distribute across nodes.

[straubt1]

Challenge

Desire to have TFE Pods to be automatically distributed across the available nodes.

In our experience without adding an affinity to our overrides, there is a chance that the 2 of the replicas will land on a single node.

Environment

GKE

• 3 Control Nodes (n2-standard-4)

TFE Helm

• replicaCount: 3

terraform-enterprise-helm/values.yaml

Line 96 in bef7aab

affinity: {}

Recommendation

Update the default to something like below to avoid the need to pass this in from the overrides (what I would argue is the typical expected behavior in production).

affinity:
  podAntiAffinity:
    requiredDuringSchedulingIgnoredDuringExecution:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - terraform-enterprise
        topologyKey: "kubernetes.io/hostname"

[carlosvilleg]

topologyKey: "kubernetes.io/zone" would be better in general