Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Onboarding tests selectors refactor #2715

Merged
merged 10 commits into from
Mar 11, 2025
Merged

Refactor: Onboarding tests selectors refactor #2715

merged 10 commits into from
Mar 11, 2025

Conversation

priya-patel04
Copy link
Collaborator

@priya-patel04 priya-patel04 commented Mar 10, 2025 •
edited
Loading

Description

Test selector refactor for onboarding tests:
onboarding
success

Screenshots (if appropriate)

How to Test

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@priya-patel04
refactor: 💡 Onboarding tests
14225b3 
Refactor test selectors for onboarding acceptance tests

✅ Closes: #ICU-16398, #ICU-16399
@priya-patel04
fix: 🐛 failing test
3a9e6fd
@priya-patel04
chore: 🤖 add copyright header
2e66f0d
@vercel Vercel
Copy link

vercel bot commented Mar 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 7:00pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 7:00pm

@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Mar 10, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app HashiCorp CLA App
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@priya-patel04 priya-patel04 marked this pull request as ready for review March 10, 2025 18:45
@priya-patel04 priya-patel04 requested a review from a team as a code owner March 10, 2025 18:45
cameronperera
cameronperera reviewed Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Left a couple of comments with some historical context.
Another thing I wanted to mention is AAA. Arrange, Act, Assert. Really it is just adding some spacing but it helps with readability in our tests. Here is a recent-ish PR where you can see spacing added for a quick example.

cameronperera
cameronperera previously approved these changes Mar 10, 2025
View reviewed changes
laurenolivia
laurenolivia previously approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@laurenolivia laurenolivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎀

calcaide
calcaide requested changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!! I left a comment 😉

@calcaide calcaide self-requested a review March 11, 2025 18:46
lisbet-alvarez
lisbet-alvarez approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@priya-patel04 priya-patel04 requested a review from calcaide March 11, 2025 19:34
calcaide
calcaide approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooo!!! nice work @priya-patel04

@priya-patel04 priya-patel04 merged commit 34a670f into main Mar 11, 2025
13 checks passed
@priya-patel04 priya-patel04 deleted the priya-patel04/onboarding_test_selector branch March 11, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcaide calcaide calcaide approved these changes

@cameronperera cameronperera cameronperera approved these changes

@lisbet-alvarez lisbet-alvarez lisbet-alvarez approved these changes

@laurenolivia laurenolivia laurenolivia left review comments

Assignees
No one assigned
Labels
admin ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@priya-patel04 @calcaide @cameronperera @laurenolivia @lisbet-alvarez