usb: gadget: f_tcm: Don't free command immediately

Thinh Nguyen · gregkh · commit 16907219ad67 · 2025-02-08T09:52:38.000+01:00
commit c225d00 upstream. Don't prematurely free the command. Wait for the status completion of the sense status. It can be freed then. Otherwise we will double-free the command. Fixes: cff834c ("usb-gadget/tcm: Convert to TARGET_SCF_ACK_KREF I/O krefs") Cc: stable@vger.kernel.org Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Link: https://lore.kernel.org/r/ae919ac431f16275e05ec819bdffb3ac5f44cbe1.1733876548.git.Thinh.Nguyen@synopsys.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
@@ -1066,7 +1066,6 @@ static void usbg_cmd_work(struct work_struct *work)
 out:
 	transport_send_check_condition_and_sense(se_cmd,
 			TCM_UNSUPPORTED_SCSI_OPCODE, 1);
-	transport_generic_free_cmd(&cmd->se_cmd, 0);
 }
 
 static struct usbg_cmd *usbg_get_cmd(struct f_uas *fu,
@@ -1195,7 +1194,6 @@ static void bot_cmd_work(struct work_struct *work)
 out:
 	transport_send_check_condition_and_sense(se_cmd,
 				TCM_UNSUPPORTED_SCSI_OPCODE, 1);
-	transport_generic_free_cmd(&cmd->se_cmd, 0);
 }
 
 static int bot_submit_command(struct f_uas *fu,

Original file line number	Diff line number	Diff line change
`@@ -1066,7 +1066,6 @@ static void usbg_cmd_work(struct work_struct *work)`
`1066`	`1066`	`out:`
`1067`	`1067`	`transport_send_check_condition_and_sense(se_cmd,`
`1068`	`1068`	`TCM_UNSUPPORTED_SCSI_OPCODE, 1);`
`1069`		`- transport_generic_free_cmd(&cmd->se_cmd, 0);`
`1070`	`1069`	`}`
`1071`	`1070`
`1072`	`1071`	`static struct usbg_cmd usbg_get_cmd(struct f_uas fu,`
`@@ -1195,7 +1194,6 @@ static void bot_cmd_work(struct work_struct *work)`
`1195`	`1194`	`out:`
`1196`	`1195`	`transport_send_check_condition_and_sense(se_cmd,`
`1197`	`1196`	`TCM_UNSUPPORTED_SCSI_OPCODE, 1);`
`1198`		`- transport_generic_free_cmd(&cmd->se_cmd, 0);`
`1199`	`1197`	`}`
`1200`	`1198`
`1201`	`1199`	`static int bot_submit_command(struct f_uas *fu,`