Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates/issues #1

Closed
JamesHenry opened this issue Feb 13, 2024 · 2 comments
Closed

Updates/issues #1

JamesHenry opened this issue Feb 13, 2024 · 2 comments

Comments

@JamesHenry
Copy link

Following on from the comments you made on the issue, I pulled down your repo to have a look.

Your release config is currently invalid, you have nested version within changelog. Additionally, the git config within changelog is unnecessary as you are just repeating the default values.

In your case your release config only needs to be:

"release": {
    "projects": [
      "packages/*"
    ],
    "version": {
      "conventionalCommits": true
    }
  },

Please be aware that you have some other issues going on:

  1. You have ignored your whole .yarn directory, so your yarn config is invalid and cannot run because of yarnPath: .yarn/releases/yarn-4.1.0.cjs and the release not existing. Consult the yarn docs for how to handle the .yarn directory, you are not supposed to ignore the whole thing.
  2. You are extending from expo/tsconfig.base in your root tsconfig.json, which does not exist. This is what is causing the false positive on the changelog renderer resolution FYI, we are swallowing the real error as discussed on the Nx repo, and I will fix that, but you will need to address this actual on your side before it works.
  3. More minor but still relevant, your formatting is currently inconsistent. Your tsconfig.base.json is using tabs and other files aren't. This will lead to a bit of noise in your version diffs when formatFiles() is applied behind the scenes.

Hope that helps!

@guillempuche
Copy link
Owner

guillempuche commented Feb 13, 2024

Ohh! Amazing advices!

In case of linting, I'm starting to use Biome as a replacement of Prettier and Eslint.

@guillempuche
Copy link
Owner

Solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants