-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider publishing grpc-gateway to Bazel Central Registry #5183
Comments
Thanks for your issue. We've talked about doing this before so it's definitely something I'd consider. Please feel free to open a PR. I want to make sure this doesn't unduly add to the maintenance burden of this repository, so I'd want publishing to the registry to happen automatically when a new release is built. I'm happy to registry any accounts and populate secrets necessary for CI. CC @AlejoAsd who helped add our bzlmod support. |
Hi @johanbrandhorst, thank you for your answer. I have been reading about publishing modules in BCR. The simplest and most recommended method is to use Publish to BCR. Process descriptionPublish to BCR is a GitHub app that mirrors releases of your Bazel ruleset to the Bazel Central Registry. The goal is that when a grpc-gateway version is released, the app will create a PR in a forked BCR repository. Initially, the released version is sanity-checked: the app runs a presubmit job, which builds and runs tests on module targets. If the tests are successful, a PR is built for the BCR. IMPORTANT: running the Process diagramConfiguration Steps
The steps are described in the Publish to BCR repo. |
Thanks for looking into this. The process sounds good to me - just one concern. Can we run the presubmit as part of our CI, to ensure there's no risk of making a release that can't pass the presubmit and make it to the BCR? I would hate to have to re-release something just because it failed the presubmit. Where would the bazel-central-registry fork live? I can create it in grpc-ecosystem, but is it a necessity? I'm happy to volunteer as the project maintainer for the purpose of creating the PRs against a user. |
Thank you for your answer. Regarding your questions:
|
Cool, I think our existing Bazel CI jobs probably already satisfy the presubmit requirements. I'm also happy to create the BCR fork in this org, maybe it can serve other repositories in this org too. |
We maintain an SDK that depends on
grpc-gateway
. We're encountering challenges with Bazel's module system, as override directives only work in root modules.Publishing grpc-gateway to BCR would:
We're willing to help with the BCR publication process if you're interested. Would you consider this addition to improve the experience for
grpc-gateway
users?The text was updated successfully, but these errors were encountered: